feat: update logging for client connect and disconnect

- update logging to use ws.RemoteAddr()

🤖

internal/websocket/client_commands.go

@@ -10,15 +10,15 @@ import (
 )
 
 // Listens for commands from a client and handles them
-func handleClientCommands(c models.Client) {
+func handleClientCommands(c models.WebsocketClient) {
 	ws := c.Conn
 	for {
 		var clientCommand models.ClientCommand
 
 		_, message, err := ws.ReadMessage()
 		if err != nil {
-			log.Info("Client disconnected:", "msg", err, "host", ws.NetConn().RemoteAddr(), "clients", len(Clients)-1)
+			log.Info("Client disconnected:", "msg", err, "host", ws.RemoteAddr(), "clients", len(Clients)-1)
-			delete(Clients, ws)
+			delete(Clients, ws.LocalAddr())
 			break
 		}
 

internal/websocket/handle_connection.go

@@ -3,14 +3,15 @@ package websocket
 import (
 	"github.com/charmbracelet/log"
 	"github.com/gorilla/websocket"
+	"net"
 	"net/http"
 	"sync"
 
 	"git.smsvc.net/pomodoro/GoTomato/pkg/models"
 )
 
-// Clients is a map of connected WebSocket clients, where each client is represented by the Client struct
+// Clients is a map of connected WebSocket clients, where each client is represented by the WebsocketClient struct
-var Clients = make(map[*websocket.Conn]*models.Client)
+var Clients = make(map[net.Addr]*models.WebsocketClient)
 var mu sync.Mutex // Mutex to protect access to the Clients map
 
 // Upgrade HTTP requests to WebSocket connections
@@ -28,14 +29,14 @@ func HandleConnection(w http.ResponseWriter, r *http.Request) {
 	}
 	defer ws.Close()
 
-	log.Info("Client connected", "host", ws.NetConn().RemoteAddr(), "clients", len(Clients)+1)
+	log.Info("Client connected", "host", ws.RemoteAddr(), "clients", len(Clients)+1)
 
 	// Register the new client
-	client := models.Client{
+	client := models.WebsocketClient{
 		Conn: ws,
 	}
 	mu.Lock()
-	Clients[ws] = &client
+	Clients[ws.LocalAddr()] = &client
 	mu.Unlock()
 
 	// Listen for commands from the connected client

pkg/models/client.go

@@ -13,13 +13,13 @@ type ClientCommand struct {
 }
 
 // Represents a single client
-type Client struct {
+type WebsocketClient struct {
 	Conn *websocket.Conn
 }
 
 // Sends a message to the websocket.
 // Automatically locks and unlocks the client mutex, to ensure that only one goroutine can write at a time.
-func (c *Client) SendMessage(messageType int, data []byte) error {
+func (c *WebsocketClient) SendMessage(messageType int, data []byte) error {
 	err := c.Conn.WriteMessage(messageType, data)
 	if err != nil {
 		log.Error("Error writing to WebSocket:", "msg", err)