Compare commits

..

No commits in common. "478ff99fdd4f32e4568ff0f22729b97ab9ed66fa" and "8295208a0b0f8dcc03a7eb61612a6053a334c1c7" have entirely different histories.

3 changed files with 13 additions and 37 deletions

View file

@ -22,12 +22,11 @@ func SendPermanentBroadCastMessage() {
// Iterate over all connected clients and broadcast the message // Iterate over all connected clients and broadcast the message
for _, client := range Clients { for _, client := range Clients {
// Remove unresponsive client if time.Now().Sub(client.LastPong) > (10 * time.Second) {
if client.IsStale() { // Remove unresponsive client
client.Conn.Close() client.Conn.Close()
continue continue
} }
// Send message to client
err := client.SendMessage(websocket.TextMessage, jsonMessage) err := client.SendMessage(websocket.TextMessage, jsonMessage)
if err != nil { if err != nil {
helper.Logger.Info("Error broadcasting to client:", "msg", err, "host", client.RealIP, "clients", len(Clients)) helper.Logger.Info("Error broadcasting to client:", "msg", err, "host", client.RealIP, "clients", len(Clients))

View file

@ -20,22 +20,6 @@ var upgrader = websocket.Upgrader{
CheckOrigin: func(r *http.Request) bool { return true }, CheckOrigin: func(r *http.Request) bool { return true },
} }
// initialize a new WebsocketClient
func newWebsocketClient(ws *websocket.Conn, address string) models.WebsocketClient {
wsclient := models.WebsocketClient{
Conn: ws,
LastPong: time.Now(),
RealIP: address,
}
wsclient.Conn.SetPongHandler(func(appData string) error {
wsclient.LastPong = time.Now()
return nil
})
return wsclient
}
// Upgrades HTTP requests to WebSocket connections and manages the client lifecycle // Upgrades HTTP requests to WebSocket connections and manages the client lifecycle
func HandleConnection(w http.ResponseWriter, r *http.Request) { func HandleConnection(w http.ResponseWriter, r *http.Request) {
// Upgrade initial GET request to a WebSocket // Upgrade initial GET request to a WebSocket
@ -47,8 +31,11 @@ func HandleConnection(w http.ResponseWriter, r *http.Request) {
defer ws.Close() defer ws.Close()
// Register the new client // Register the new client
client := newWebsocketClient(ws, r.RemoteAddr) client := models.WebsocketClient{
Conn: ws,
LastPong: time.Now(),
RealIP: r.RemoteAddr,
}
mu.Lock() mu.Lock()
Clients[ws.LocalAddr()] = &client Clients[ws.LocalAddr()] = &client
mu.Unlock() mu.Unlock()

View file

@ -24,22 +24,12 @@ type WebsocketClient struct {
// Sends a message to the websocket. // Sends a message to the websocket.
func (c *WebsocketClient) SendMessage(messageType int, data []byte) error { func (c *WebsocketClient) SendMessage(messageType int, data []byte) error {
c.Conn.SetWriteDeadline(time.Now().Add(TIMEOUT * time.Second)) c.Conn.SetPongHandler(func(s string) error {
err := c.Conn.WriteMessage(websocket.PingMessage, nil) c.LastPong = time.Now()
if err != nil { return nil
return err })
}
c.Conn.SetWriteDeadline(time.Now().Add(TIMEOUT * time.Second)) c.Conn.SetWriteDeadline(time.Now().Add(TIMEOUT * time.Second))
err = c.Conn.WriteMessage(messageType, data) c.Conn.WriteMessage(websocket.PingMessage, nil)
if err != nil { return c.Conn.WriteMessage(messageType, data)
return err
}
return nil
}
// Check if websockets last Pong is recent
func (c *WebsocketClient) IsStale() bool {
return time.Since(c.LastPong) > (TIMEOUT * time.Second)
} }