feat: remove unused client mutex

- remove unused Mutex from `models.Client` struct
- remove lock from `HandleConnection()`
- replace websocket.Conn with models.Client in `handleClientCommands()`

🤖

internal/pomodoro/pomodoro.go

@@ -42,7 +42,7 @@ func RunPomodoro() {
 
 		// Work
 		shared.State.Mode = "Work"
-		go timer.Start(pomodoroConfig.Work)
+		timer.StartAsync(pomodoroConfig.Work)
 		if !waitForTimer(timer) {
 			break
 		}
@@ -50,13 +50,13 @@ func RunPomodoro() {
 		// Breaks
 		if session < pomodoroConfig.Sessions {
 			shared.State.Mode = "ShortBreak"
-			go timer.Start(pomodoroConfig.ShortBreak)
+			timer.StartAsync(pomodoroConfig.ShortBreak)
 			if !waitForTimer(timer) {
 				break
 			}
 		} else { // last phase, prepare for finish
 			shared.State.Mode = "LongBreak"
-			go timer.Start(pomodoroConfig.LongBreak)
+			timer.StartAsync(pomodoroConfig.LongBreak)
 			if !waitForTimer(timer) {
 				break
 			}

internal/pomodoro/timer.go

@@ -24,7 +24,12 @@ func (t Timer) Init() Timer {
 	}
 }
 
-// Start the timer
+// Start the timer (goroutine)
+func (t *Timer) StartAsync(duration int) {
+	go t.Start(duration)
+}
+
+// Start the timer (blocking)
 func (t *Timer) Start(duration int) {
 	tick := time.NewTicker(time.Second)
 	for timeLeft := duration; timeLeft > 0; {

internal/websocket/client_commands.go

@@ -3,7 +3,6 @@ package websocket
 import (
 	"encoding/json"
 	"github.com/charmbracelet/log"
-	"github.com/gorilla/websocket"
 
 	"git.smsvc.net/pomodoro/GoTomato/internal/pomodoro"
 	"git.smsvc.net/pomodoro/GoTomato/internal/shared"
@@ -11,7 +10,8 @@ import (
 )
 
 // Listens for commands from a client and handles them
-func handleClientCommands(ws *websocket.Conn) {
+func handleClientCommands(c models.Client) {
+	ws := c.Conn
 	for {
 		var clientCommand models.ClientCommand
 

internal/websocket/handle_connection.go

@@ -31,12 +31,13 @@ func HandleConnection(w http.ResponseWriter, r *http.Request) {
 	log.Info("Client connected", "host", ws.NetConn().RemoteAddr(), "clients", len(Clients)+1)
 
 	// Register the new client
-	mu.Lock()
-	Clients[ws] = &models.Client{
-		Conn: ws, // Store the WebSocket connection
+	client := models.Client{
+		Conn: ws,
 	}
+	mu.Lock()
+	Clients[ws] = &client
 	mu.Unlock()
 
 	// Listen for commands from the connected client
-	handleClientCommands(ws)
+	handleClientCommands(client)
 }

pkg/models/client.go

@@ -3,7 +3,6 @@ package models
 import (
 	"github.com/charmbracelet/log"
 	"github.com/gorilla/websocket"
-	"sync"
 )
 
 // Represents a command from the client (start/stop)
@@ -15,16 +14,12 @@ type ClientCommand struct {
 
 // Represents a single client
 type Client struct {
-	Conn  *websocket.Conn // Websocket connection of the client
-	Mutex sync.Mutex      // Mutex used to lock
+	Conn *websocket.Conn
 }
 
 // Sends a message to the websocket.
 // Automatically locks and unlocks the client mutex, to ensure that only one goroutine can write at a time.
 func (c *Client) SendMessage(messageType int, data []byte) error {
-	c.Mutex.Lock()
-	defer c.Mutex.Unlock()
-
 	err := c.Conn.WriteMessage(messageType, data)
 	if err != nil {
 		log.Error("Error writing to WebSocket:", "msg", err)